Repository navigation
Conversation
ade7f84 to
46838da
Compare
|
how emotionally attached are you to |
|
I only stumbled over it through the tool. It looked just like the smallest change. |
it is, that's true, but it's widely adopted and regularly updated. Also this is a beast of a PR :) |
5195e67 to
048eb6d
Compare
Fill the operator settings from module-owned options structs via go-flagsfiller, so introducing a parameter only touches the options struct and the chart's env values: the flag and the environment binding hook up automatically. Keep the command-line flags so users can inspect the options. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
The manager reads its settings from the environment, so drop the --flag=$(ENV_VAR) container arguments. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
settings now live next to their owning controllers, so adding a setting touches one file per controller plus the chart Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
6921cfc to
7161ff1
Compare
Merging this branch will decrease overall coverage
Coverage detailsCompared to commit cfee313 (run #43438290245)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
Parse the operator configuration into module-owned options structs filled by
go-flagsfiller, so introducing a
parameter only touches the options struct and the chart's env values: the
flag and environment binding hook up automatically,
--helpdocuments them,and invalid values fail once at startup. The chart drops the
--flag=$(ENV_VAR)arguments in a separate, revertable commit.Existing tests are updated for the option wiring; no new tests.
Relates to #13.
Layout reduction round (2026-11-01)
Controller-owned options now live in their controller files:
internal/controller/eviction/controller.gointernal/controller/node_certificate_controller.gointernal/controller/hypervisor_controller.go(used by the manager and the Hypervisor controller only)The separate
internal/controller/eviction/options.go,internal/controller/options.go, andinternal/config/options.gofiles no longer exist.Churn vs PR base (added + deleted lines): 408 → 345.
Future settings: add the field (tag + default) to the owning options struct in its controller file — no central registration. Separate new semantic field groups with a blank line to keep reformatting churn low.